Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 97f44f56 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: Limit the fallback card id string size 



When no proper id string is given, the driver tries to fall back to
copy the proc_root name string via strcpy(), but this might overflow
the fixed string size.  Let's use strlcpy().

Spotted by coverity CID 139008.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 75415df8

sound/core/init.c

+1 −1
Original line number Diff line number Diff line
@@ -597,7 +597,7 @@ static void snd_card_set_id_no_lock(struct snd_card *card, const char *src, 
	/* last resort... */

	snd_printk(KERN_ERR "unable to set card id (%s)\n", id);

	if (card->proc_root->name)

		strcpy(card->id, card->proc_root->name);

		strlcpy(card->id, card->proc_root->name, sizeof(card->id));

}



/**