Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9728e5d6 authored by Tetsuo Handa's avatar Tetsuo Handa Committed by Linus Torvalds
Browse files

kernel/pid.c: update comment on find_task_by_pid_ns 



tasklist_lock does protect the task and its pid, it can't go away.  The
problem is that find_pid_ns() itself is unsafe without rcu lock, it can
race with copy_process()->free_pid(any_pid).

Protecting copy_process()->free_pid(any_pid) with tasklist_lock would make
it possible to call find_task_by_pid_ns() under tasklist safely, but we
don't do so because we are trying to get rid of the read_lock sites of
tasklist_lock.

Signed-off-by: default avatarTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: "Paul E. McKenney" <paulmck@us.ibm.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 8aeee85a

kernel/pid.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -376,7 +376,7 @@ struct task_struct *pid_task(struct pid *pid, enum pid_type type) 
EXPORT_SYMBOL(pid_task);

EXPORT_SYMBOL(pid_task);





/*

/*

 * Must be called under rcu_read_lock() or with tasklist_lock read-held.

 * Must be called under rcu_read_lock().

 */

 */

struct task_struct *find_task_by_pid_ns(pid_t nr, struct pid_namespace *ns)

struct task_struct *find_task_by_pid_ns(pid_t nr, struct pid_namespace *ns)

{

{