Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96f6f985 authored by Al Viro's avatar Al Viro
Browse files

nfsd: fix b0rken error value for setattr on read-only mount 



..._want_write() returns -EROFS on failure, _not_ an NFS error value.

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent ecca5c3a

fs/nfsd/nfs4proc.c

+4 −3
Original line number Diff line number Diff line
@@ -841,6 +841,7 @@ nfsd4_setattr(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, 
	      struct nfsd4_setattr *setattr)

{

	__be32 status = nfs_ok;

	int err;



	if (setattr->sa_iattr.ia_valid & ATTR_SIZE) {

		nfs4_lock_state();
@@ -852,9 +853,9 @@ nfsd4_setattr(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, 
			return status;

		}

	}

	status = fh_want_write(&cstate->current_fh);

	if (status)

		return status;

	err = fh_want_write(&cstate->current_fh);

	if (err)

		return nfserrno(err);

	status = nfs_ok;



	status = check_attr_support(rqstp, cstate, setattr->sa_bmval,