Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96ec2e0a authored by Theodore Ts'o's avatar Theodore Ts'o Committed by Jan Kara
Browse files

ext3: Don't update superblock write time when filesystem is read-only 



This avoids updating the superblock write time when we are mounting
the root file system read/only but we need to replay the journal; at
that point, for people who are east of GMT and who make their clock
tick in localtime for Windows bug-for-bug compatibility, and this will
cause e2fsck to complain and force a full file system check.

Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent 2caa7318

fs/ext3/super.c

+12 −1
Original line number Original line Diff line number Diff line
@@ -2321,6 +2321,17 @@ static int ext3_commit_super(struct super_block *sb, 




	if (!sbh)

	if (!sbh)

		return error;

		return error;

	/*

	 * If the file system is mounted read-only, don't update the

	 * superblock write time.  This avoids updating the superblock

	 * write time when we are mounting the root file system

	 * read/only but we need to replay the journal; at that point,

	 * for people who are east of GMT and who make their clock

	 * tick in localtime for Windows bug-for-bug compatibility,

	 * the clock is set in the future, and this will cause e2fsck

	 * to complain and force a full file system check.

	 */

	if (!(sb->s_flags & MS_RDONLY))

		es->s_wtime = cpu_to_le32(get_seconds());

		es->s_wtime = cpu_to_le32(get_seconds());

	es->s_free_blocks_count = cpu_to_le32(ext3_count_free_blocks(sb));

	es->s_free_blocks_count = cpu_to_le32(ext3_count_free_blocks(sb));

	es->s_free_inodes_count = cpu_to_le32(ext3_count_free_inodes(sb));

	es->s_free_inodes_count = cpu_to_le32(ext3_count_free_inodes(sb));