Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96d7b43b authored by David Arcari's avatar David Arcari Committed by Greg Kroah-Hartman
Browse files

cpufreq: cpufreq_register_driver() should return -ENODEV if init fails 



commit 6c77003677d5f1ce15f26d24360cb66c0bc07bb3 upstream.

For a driver that does not set the CPUFREQ_STICKY flag, if all of the
->init() calls fail, cpufreq_register_driver() should return an error.
This will prevent the driver from loading.

Fixes: ce1bcfe9 (cpufreq: check cpufreq_policy_list instead of scanning policies for all CPUs)
Signed-off-by: default avatarDavid Arcari <darcari@redhat.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent acd8f917

drivers/cpufreq/cpufreq.c

+1 −0
Original line number Diff line number Diff line
@@ -2474,6 +2474,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data) 
	if (!(cpufreq_driver->flags & CPUFREQ_STICKY) &&

	    list_empty(&cpufreq_policy_list)) {

		/* if all ->init() calls failed, unregister */

		ret = -ENODEV;

		pr_debug("%s: No CPU initialized for driver %s\n", __func__,

			 driver_data->name);

		goto err_if_unreg;