Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96b4a8ac authored by Jon Maloy's avatar Jon Maloy Committed by Greg Kroah-Hartman
Browse files

tipc: fix memory leak in tipc_accept_from_sock() 




[ Upstream commit a7d5f107b4978e08eeab599ee7449af34d034053 ]

When the function tipc_accept_from_sock() fails to create an instance of
struct tipc_subscriber it omits to free the already created instance of
struct tipc_conn instance before it returns.

We fix that with this commit.

Reported-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarJon Maloy <jon.maloy@ericsson.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 20610f5b

net/tipc/server.c

+1 −0
Original line number Diff line number Diff line
@@ -313,6 +313,7 @@ static int tipc_accept_from_sock(struct tipc_conn *con) 
	newcon->usr_data = s->tipc_conn_new(newcon->conid);

	if (!newcon->usr_data) {

		sock_release(newsock);

		conn_put(newcon);

		return -ENOMEM;

	}