Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9580dce3 authored by c_mtharu's avatar c_mtharu
Browse files

msm: ADSPRPC: Use spin_lock_irqsave in glink notify handler 



Use appropriate spin lock and unlock functions with irq save and
restore in glink notify handler to avoid deadlock.

Change-Id: I3cf87a9a7ec098b8c5de62501440ca3f0b977abf
Acked-by: default avatarViswanatham Paduchuri <vpaduchu@qti.qualcomm.com>
Signed-off-by: default avatarTharun Kumar Merugu <mtharu@codeaurora.org>
parent 4e64e456

drivers/char/adsprpc.c

+6 −4
Original line number Diff line number Diff line
@@ -1830,16 +1830,18 @@ static int fastrpc_search_ctx(uint64_t rctx) 
	struct smq_invoke_ctx *ictx = NULL;

	struct smq_invoke_ctx *ctx;

	int bfound = 0;

	unsigned long flags;

	unsigned long flags1;



	ctx = (struct smq_invoke_ctx *)(uint64_to_ptr(rctx));

	if (!ctx)

		return bfound;



	spin_lock(&me->hlock);

	spin_lock_irqsave(&me->hlock, flags);

	hlist_for_each_entry_safe(fl, n, &me->drivers, hn) {

		if (ctx->fl != fl)

			continue;

		spin_lock(&fl->hlock);

		spin_lock_irqsave(&fl->hlock, flags1);

		hlist_for_each_entry_safe(ictx, m, &fl->clst.pending, hn) {

			if (ptr_to_uint64(ictx) == rctx) {

				bfound = 1;
@@ -1852,11 +1854,11 @@ static int fastrpc_search_ctx(uint64_t rctx) 
				break;

			}

		}

		spin_unlock(&fl->hlock);

		spin_unlock_irqrestore(&fl->hlock, flags1);

		if (bfound)

			break;

	}

	spin_unlock(&me->hlock);

	spin_unlock_irqrestore(&me->hlock, flags);

	return bfound;

}