Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9560fe63 authored by Daniel Rosenberg's avatar Daniel Rosenberg
Browse files

Revert "Android: sdcardfs: Don't do d_add for lower fs" 



This reverts commit ab16e2fd.

This change caused issues for sdcardfs on top of vfat

Signed-off-by: default avatarDaniel Rosenberg <drosen@google.com>
Change-Id: I34918eed57a8b566c58f8083de12a93a12ba5857
parent 33efe54e

fs/sdcardfs/lookup.c

+7 −5
Original line number Diff line number Diff line
@@ -368,15 +368,17 @@ static struct dentry *__sdcardfs_lookup(struct dentry *dentry, 
	dname.len = name->len;

	dname.hash = full_name_hash(lower_dir_dentry, dname.name, dname.len);

	lower_dentry = d_lookup(lower_dir_dentry, &dname);

	if (lower_dentry)

		goto setup_lower;



	lower_dentry = d_alloc(lower_dir_dentry, &dname);

	if (!lower_dentry) {

		/* We called vfs_path_lookup earlier, and did not get a negative

		 * dentry then. Don't confuse the lower filesystem by forcing one

		 * on it now...

		 */

		err = -ENOENT;

		err = -ENOMEM;

		goto out;

	}

	d_add(lower_dentry, NULL); /* instantiate and hash */



setup_lower:

	lower_path.dentry = lower_dentry;

	lower_path.mnt = mntget(lower_dir_mnt);

	sdcardfs_set_lower_path(dentry, &lower_path);