Commit 951179ce authored Nov 02, 2012 by Guo Chao Committed by Marcelo Tosatti Nov 13, 2012

KVM: x86: fix return value of kvm_vm_ioctl_set_tss_addr()



Return value of this function will be that of ioctl().

#include <stdio.h>
#include <linux/kvm.h>

int main () {
	int fd;
	fd = open ("/dev/kvm", 0);
	fd = ioctl (fd, KVM_CREATE_VM, 0);
	ioctl (fd, KVM_SET_TSS_ADDR, 0xfffff000);
	perror ("");
	return 0;
}

Output is "Operation not permitted". That's not what
we want.

Return -EINVAL in this case.

Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

parent 18595411

arch/x86/kvm/x86.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2946,7 +2946,7 @@ static int kvm_vm_ioctl_set_tss_addr(struct kvm *kvm, unsigned long addr)
		int ret;

		if (addr > (unsigned int)(-3 * PAGE_SIZE))
		return -1;
		return -EINVAL;
		ret = kvm_x86_ops->set_tss_addr(kvm, addr);
		return ret;
		}