Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 949cf706 authored by Fugang Duan's avatar Fugang Duan Committed by Mauro Carvalho Chehab
Browse files

[media] radio-si476x: add return value check to avoid dead code 



Dead code found on below code:
    si476x_radio_add_new_custom(radio, SI476X_IDX_DIVERSITY_MODE);
    if (rval < 0)
            goto exit;

    si476x_radio_add_new_custom(radio, SI476X_IDX_INTERCHIP_LINK);
    if (rval < 0)  ====> Dead code !!!
            goto exit;

The piece of code miss return value check after calling .si476x_radio_add_new_custom(),
the patch fix it.

Signed-off-by: default avatarFugang Duan <B38611@freescale.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 9dd73448

drivers/media/radio/radio-si476x.c

+2 −2
Original line number Diff line number Diff line
@@ -1530,11 +1530,11 @@ static int si476x_radio_probe(struct platform_device *pdev) 
	if (si476x_core_has_diversity(radio->core)) {

		si476x_ctrls[SI476X_IDX_DIVERSITY_MODE].def =

			si476x_phase_diversity_mode_to_idx(radio->core->diversity_mode);

		si476x_radio_add_new_custom(radio, SI476X_IDX_DIVERSITY_MODE);

		rval = si476x_radio_add_new_custom(radio, SI476X_IDX_DIVERSITY_MODE);

		if (rval < 0)

			goto exit;



		si476x_radio_add_new_custom(radio, SI476X_IDX_INTERCHIP_LINK);

		rval = si476x_radio_add_new_custom(radio, SI476X_IDX_INTERCHIP_LINK);

		if (rval < 0)

			goto exit;

	}