Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 949bdd20 authored by Rickard Strandqvist's avatar Rickard Strandqvist Committed by David S. Miller
Browse files

net: ethernet: freescale: fec_main.c: Cleaning up missing null-terminate in...


net: ethernet: freescale: fec_main.c: Cleaning up missing null-terminate in conjunction with strncpy

Replacing strncpy with strlcpy to avoid strings that lacks null terminate.

Signed-off-by: default avatarRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 17b6f244
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -1846,13 +1846,13 @@ static int fec_enet_mii_probe(struct net_device *ndev)
				continue;
			if (dev_id--)
				continue;
			strncpy(mdio_bus_id, fep->mii_bus->id, MII_BUS_ID_SIZE);
			strlcpy(mdio_bus_id, fep->mii_bus->id, MII_BUS_ID_SIZE);
			break;
		}

		if (phy_id >= PHY_MAX_ADDR) {
			netdev_info(ndev, "no PHY, assuming direct connection to switch\n");
			strncpy(mdio_bus_id, "fixed-0", MII_BUS_ID_SIZE);
			strlcpy(mdio_bus_id, "fixed-0", MII_BUS_ID_SIZE);
			phy_id = 0;
		}