Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9498dc95 authored by Sonic Zhang's avatar Sonic Zhang Committed by Greg Kroah-Hartman
Browse files

serial: bfin_sport_uart: protect changes to uart_port 



Common serial API says we need to grab the port lock before modifying
the port state to prevent inconsistent state between threads.

Signed-off-by: default avatarSonic Zhang <sonic.zhang@analog.com>
Signed-off-by: default avatarMike Frysinger <vapier@gentoo.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 1f7d1c85

drivers/serial/bfin_sport_uart.c

+2 −2
Original line number Diff line number Diff line
@@ -498,6 +498,8 @@ static void sport_set_termios(struct uart_port *port, 
		/* up->parib = 1; */

	}



	spin_lock_irqsave(&up->port.lock, flags);



	port->read_status_mask = OE;

	if (termios->c_iflag & INPCK)

		port->read_status_mask |= (FE | PE);
@@ -538,8 +540,6 @@ static void sport_set_termios(struct uart_port *port, 
	/* uart baud rate */

	port->uartclk = uart_get_baud_rate(port, termios, old, 0, get_sclk()/16);



	spin_lock_irqsave(&up->port.lock, flags);



	/* Disable UART */

	SPORT_PUT_TCR1(up, SPORT_GET_TCR1(up) & ~TSPEN);

	SPORT_PUT_RCR1(up, SPORT_GET_RCR1(up) & ~RSPEN);