Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 94634e98 authored by Nicholas Mc Guire's avatar Nicholas Mc Guire Committed by Doug Ledford
Browse files

IB/ehca: use correct destination for memcpy 



Using an element of a struct as the address for the memcpy of the whole
struct may introduce a buffer overflow and does not help readability either
simply pass the real thing as first argument to memcpy.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarNicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent b6b2bbe6

drivers/infiniband/hw/ehca/ehca_mcast.c

+2 −2
Original line number Diff line number Diff line
@@ -77,7 +77,7 @@ int ehca_attach_mcast(struct ib_qp *ibqp, union ib_gid *gid, u16 lid) 
		return -EINVAL;

	}



	memcpy(&my_gid.raw, gid->raw, sizeof(union ib_gid));

	memcpy(&my_gid, gid->raw, sizeof(union ib_gid));



	subnet_prefix = be64_to_cpu(my_gid.global.subnet_prefix);

	interface_id = be64_to_cpu(my_gid.global.interface_id);
@@ -114,7 +114,7 @@ int ehca_detach_mcast(struct ib_qp *ibqp, union ib_gid *gid, u16 lid) 
		return -EINVAL;

	}



	memcpy(&my_gid.raw, gid->raw, sizeof(union ib_gid));

	memcpy(&my_gid, gid->raw, sizeof(union ib_gid));



	subnet_prefix = be64_to_cpu(my_gid.global.subnet_prefix);

	interface_id = be64_to_cpu(my_gid.global.interface_id);