Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9451d1bd authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

media: gspca/sq905: fix control-request direction 



commit 53ae298fde7adcc4b1432bce2dbdf8dac54dfa72 upstream.

The direction of the pipe argument must match the request-type direction
bit or control requests may fail depending on the host-controller-driver
implementation.

Fix the USB_REQ_SYNCH_FRAME request which erroneously used
usb_sndctrlpipe().

Fixes: 27d35fc3 ("V4L/DVB (10639): gspca - sq905: New subdriver.")
Cc: stable@vger.kernel.org      # 2.6.30
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bbc80a97

drivers/media/usb/gspca/sq905.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -130,7 +130,7 @@ static int sq905_command(struct gspca_dev *gspca_dev, u16 index) 
	}

	}





	ret = usb_control_msg(gspca_dev->dev,

	ret = usb_control_msg(gspca_dev->dev,

			      usb_sndctrlpipe(gspca_dev->dev, 0),

			      usb_rcvctrlpipe(gspca_dev->dev, 0),

			      USB_REQ_SYNCH_FRAME,                /* request */

			      USB_REQ_SYNCH_FRAME,                /* request */

			      USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE,

			      USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE,

			      SQ905_PING, 0, gspca_dev->usb_buf, 1,

			      SQ905_PING, 0, gspca_dev->usb_buf, 1,