Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 93f93a44 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

net: move skb_mark_napi_id() into core networking stack 



We would like to automatically provide busy polling support
to all NAPI drivers, without them having to implement anything.

skb_mark_napi_id() can be called from napi_gro_receive() and
napi_get_frags().

Few drivers are still calling skb_mark_napi_id() because
they use netif_receive_skb(). They should eventually call
napi_gro_receive() instead. I will leave this to drivers
maintainers.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 868fdb06

drivers/net/ethernet/amd/xgbe/xgbe-drv.c

+0 −1
Original line number Diff line number Diff line
@@ -2024,7 +2024,6 @@ static int xgbe_rx_poll(struct xgbe_channel *channel, int budget) 
		skb->dev = netdev;

		skb->protocol = eth_type_trans(skb, netdev);

		skb_record_rx_queue(skb, channel->queue_index);

		skb_mark_napi_id(skb, napi);



		napi_gro_receive(napi, skb);

drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c

+0 −2
Original line number Diff line number Diff line
@@ -1094,8 +1094,6 @@ static int bnx2x_rx_int(struct bnx2x_fastpath *fp, int budget) 
			__vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q),

					       le16_to_cpu(cqe_fp->vlan_tag));



		skb_mark_napi_id(skb, &fp->napi);



		napi_gro_receive(&fp->napi, skb);

next_rx:

		rx_buf->data = NULL;

drivers/net/ethernet/chelsio/cxgb4/sge.c

+0 −1
Original line number Diff line number Diff line
@@ -1864,7 +1864,6 @@ static void do_gro(struct sge_eth_rxq *rxq, const struct pkt_gl *gl, 
	skb->truesize += skb->data_len;

	skb->ip_summed = CHECKSUM_UNNECESSARY;

	skb_record_rx_queue(skb, rxq->rspq.idx);

	skb_mark_napi_id(skb, &rxq->rspq.napi);

	pi = netdev_priv(skb->dev);

	if (pi->rxtstamp)

		cxgb4_sgetim_to_hwtstamp(adapter, skb_hwtstamps(skb),

drivers/net/ethernet/emulex/benet/be_main.c

+0 −1
Original line number Diff line number Diff line
@@ -2184,7 +2184,6 @@ static void be_rx_compl_process_gro(struct be_rx_obj *rxo, 
		skb_set_hash(skb, rxcp->rss_hash, PKT_HASH_TYPE_L3);



	skb->csum_level = rxcp->tunneled;

	skb_mark_napi_id(skb, napi);



	if (rxcp->vlanf)

		__vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), rxcp->vlan_tag);

drivers/net/ethernet/intel/i40e/i40e_txrx.c

+0 −1
Original line number Diff line number Diff line
@@ -1632,7 +1632,6 @@ static int i40e_clean_rx_irq_ps(struct i40e_ring *rx_ring, int budget) 
			continue;

		}

#endif

		skb_mark_napi_id(skb, &rx_ring->q_vector->napi);

		i40e_receive_skb(rx_ring, skb, vlan_tag);



		rx_desc->wb.qword1.status_error_len = 0;