Commit 93ec3029 authored Jan 24, 2016 by Amitoj Kaur Chawla Committed by Thierry Reding Mar 16, 2016

gpu: host1x: bus: Add missing of_node_put()



for_each_child_of_node() performs an of_node_get() on each iteration, so
to break out of the loop an of_node_put() is required.

Found using Coccinelle. The semantic patch used for this is as follows:

// <smpl>
@@
expression e;
local idexpression n;
@@

 for_each_child_of_node(..., n) {
   ... when != of_node_put(n)
       when != e = n
(
   return n;
|
+  of_node_put(n);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>

parent 92e963f5

drivers/gpu/host1x/bus.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -82,10 +82,12 @@ static int host1x_device_parse_dt(struct host1x_device *device,
		if (of_match_node(driver->subdevs, np) &&
		of_device_is_available(np)) {
		err = host1x_subdev_add(device, np);
		if (err < 0)
		if (err < 0) {
		of_node_put(np);
		return err;
		}
		}
		}

		return 0;
		}