Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 92cf9f8f authored by Li Zefan's avatar Li Zefan Committed by Ingo Molnar
Browse files

ksym_tracer: Fix validation of length of access type 



Don't take newline into account, otherwise:

 # echo 'pid_max:-w-' > ksym_trace_filter
 # echo -n 'pid_max:rw-' > ksym_trace_filter
 bash: echo: write error: Invalid argument

Signed-off-by: default avatarLi Zefan <lizf@cn.fujitsu.com>
Acked-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
Cc: "K.Prasad" <prasad@linux.vnet.ibm.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <4A52E2EB.9070503@cn.fujitsu.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent f088e547

kernel/trace/trace_ksym.c

+7 −7
Original line number Diff line number Diff line
@@ -158,21 +158,21 @@ static int ksym_trace_get_access_type(char *str) 
static int parse_ksym_trace_str(char *input_string, char **ksymname,

							unsigned long *addr)

{

	char *delimiter = ":";

	int ret;



	ret = -EINVAL;

	*ksymname = strsep(&input_string, delimiter);

	strstrip(input_string);



	*ksymname = strsep(&input_string, ":");

	*addr = kallsyms_lookup_name(*ksymname);



	/* Check for malformed request: (2), (1) and (5) */

	if ((!input_string) ||

		(strlen(input_string) != (KSYM_TRACER_OP_LEN + 1)) ||

	    (strlen(input_string) != KSYM_TRACER_OP_LEN) ||

	    (*addr == 0))

		goto return_code;

		return -EINVAL;;



	ret = ksym_trace_get_access_type(input_string);



return_code:

	return ret;

}