Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 92b15822 authored by Roland Dreier's avatar Roland Dreier
Browse files

IB/uverbs: Don't decrement usecnt on error paths 



In error paths when destroying an object, uverbs should not decrement
associated objects' usecnt, since ib_dereg_mr(), ib_destroy_qp(),
etc. already do that.

Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
parent 77f76013

drivers/infiniband/core/uverbs_cmd.c

+0 −7
Original line number Diff line number Diff line
@@ -492,7 +492,6 @@ ssize_t ib_uverbs_reg_mr(struct ib_uverbs_file *file, 


err_unreg:

	ib_dereg_mr(mr);

	atomic_dec(&pd->usecnt);



err_up:

	mutex_unlock(&ib_uverbs_idr_mutex);
@@ -986,11 +985,6 @@ ssize_t ib_uverbs_create_qp(struct ib_uverbs_file *file, 


err_destroy:

	ib_destroy_qp(qp);

	atomic_dec(&pd->usecnt);

	atomic_dec(&attr.send_cq->usecnt);

	atomic_dec(&attr.recv_cq->usecnt);

	if (attr.srq)

		atomic_dec(&attr.srq->usecnt);



err_up:

	mutex_unlock(&ib_uverbs_idr_mutex);
@@ -1888,7 +1882,6 @@ ssize_t ib_uverbs_create_srq(struct ib_uverbs_file *file, 


err_destroy:

	ib_destroy_srq(srq);

	atomic_dec(&pd->usecnt);



err_up:

	mutex_unlock(&ib_uverbs_idr_mutex);