Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 927d3f8f authored by Sebastian Reichel's avatar Sebastian Reichel
Browse files

HSI: omap_ssi_core: remove pm_runtime_get_sync call from tasklet 



We may not call pm_runtime_get_sync() from tasklet, since
it can block once pm_runtime_irq_safe is removed for omap-ssi.

Since irq can should only be created for a running device,
we assume, that the device is already running and use non-
synchronous API instead.

Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
Tested-by: default avatarPavel Machek <pavel@ucw.cz>
parent ea88f717

drivers/hsi/controllers/omap_ssi_core.c

+7 −1
Original line number Diff line number Diff line
@@ -255,7 +255,13 @@ static void ssi_gdd_tasklet(unsigned long dev) 
	unsigned int lch;

	u32 status_reg;



	pm_runtime_get_sync(ssi->device.parent);

	pm_runtime_get(ssi->device.parent);



	if (!pm_runtime_active(ssi->device.parent)) {

		dev_warn(ssi->device.parent, "ssi_gdd_tasklet called without runtime PM!\n");

		pm_runtime_put(ssi->device.parent);

		return;

	}



	status_reg = readl(sys + SSI_GDD_MPU_IRQ_STATUS_REG);

	for (lch = 0; lch < SSI_MAX_GDD_LCH; lch++) {