Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 91e60eb6 authored by Ursula Braun's avatar Ursula Braun Committed by David S. Miller
Browse files

s390/iucv: do not use arrays as argument 



The iucv code uses arrays as arguments. Even though this does not
really cause a problem, it could be misleading, since the compiler
turns array arguments into just a pointer argument. To be more
precise this patch changes the array arguments into pointers.

Signed-off-by: default avatarUrsula Braun <ursula.braun@de.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4d7def2a

drivers/s390/char/monreader.c

+2 −2
Original line number Diff line number Diff line
@@ -229,7 +229,7 @@ static struct mon_msg *mon_next_message(struct mon_private *monpriv) 
/******************************************************************************

 *                               IUCV handler                                 *

 *****************************************************************************/

static void mon_iucv_path_complete(struct iucv_path *path, u8 ipuser[16])

static void mon_iucv_path_complete(struct iucv_path *path, u8 *ipuser)

{

	struct mon_private *monpriv = path->private;
@@ -237,7 +237,7 @@ static void mon_iucv_path_complete(struct iucv_path *path, u8 ipuser[16]) 
	wake_up(&mon_conn_wait_queue);

}



static void mon_iucv_path_severed(struct iucv_path *path, u8 ipuser[16])

static void mon_iucv_path_severed(struct iucv_path *path, u8 *ipuser)

{

	struct mon_private *monpriv = path->private;

drivers/s390/char/vmlogrdr.c

+4 −4
Original line number Diff line number Diff line
@@ -99,8 +99,8 @@ static const struct file_operations vmlogrdr_fops = { 
};





static void vmlogrdr_iucv_path_complete(struct iucv_path *, u8 ipuser[16]);

static void vmlogrdr_iucv_path_severed(struct iucv_path *, u8 ipuser[16]);

static void vmlogrdr_iucv_path_complete(struct iucv_path *, u8 *ipuser);

static void vmlogrdr_iucv_path_severed(struct iucv_path *, u8 *ipuser);

static void vmlogrdr_iucv_message_pending(struct iucv_path *,

					  struct iucv_message *);
@@ -160,7 +160,7 @@ static struct cdev *vmlogrdr_cdev = NULL; 
static int recording_class_AB;





static void vmlogrdr_iucv_path_complete(struct iucv_path *path, u8 ipuser[16])

static void vmlogrdr_iucv_path_complete(struct iucv_path *path, u8 *ipuser)

{

	struct vmlogrdr_priv_t * logptr = path->private;
@@ -171,7 +171,7 @@ static void vmlogrdr_iucv_path_complete(struct iucv_path *path, u8 ipuser[16]) 
}





static void vmlogrdr_iucv_path_severed(struct iucv_path *path, u8 ipuser[16])

static void vmlogrdr_iucv_path_severed(struct iucv_path *path, u8 *ipuser)

{

	struct vmlogrdr_priv_t * logptr = path->private;

	u8 reason = (u8) ipuser[8];

drivers/s390/net/netiucv.c

+10 −11
Original line number Diff line number Diff line
@@ -149,12 +149,11 @@ static struct device_driver netiucv_driver = { 
	.pm = &netiucv_pm_ops,

};



static int netiucv_callback_connreq(struct iucv_path *,

				    u8 ipvmid[8], u8 ipuser[16]);

static void netiucv_callback_connack(struct iucv_path *, u8 ipuser[16]);

static void netiucv_callback_connrej(struct iucv_path *, u8 ipuser[16]);

static void netiucv_callback_connsusp(struct iucv_path *, u8 ipuser[16]);

static void netiucv_callback_connres(struct iucv_path *, u8 ipuser[16]);

static int netiucv_callback_connreq(struct iucv_path *, u8 *, u8 *);

static void netiucv_callback_connack(struct iucv_path *, u8 *);

static void netiucv_callback_connrej(struct iucv_path *, u8 *);

static void netiucv_callback_connsusp(struct iucv_path *, u8 *);

static void netiucv_callback_connres(struct iucv_path *, u8 *);

static void netiucv_callback_rx(struct iucv_path *, struct iucv_message *);

static void netiucv_callback_txdone(struct iucv_path *, struct iucv_message *);
@@ -556,8 +555,8 @@ static void netiucv_callback_connack(struct iucv_path *path, u8 ipuser[16]) 
	fsm_event(conn->fsm, CONN_EVENT_CONN_ACK, conn);

}



static int netiucv_callback_connreq(struct iucv_path *path,

				    u8 ipvmid[8], u8 ipuser[16])

static int netiucv_callback_connreq(struct iucv_path *path, u8 *ipvmid,

				    u8 *ipuser)

{

	struct iucv_connection *conn = path->private;

	struct iucv_event ev;
@@ -587,21 +586,21 @@ static int netiucv_callback_connreq(struct iucv_path *path, 
	return rc;

}



static void netiucv_callback_connrej(struct iucv_path *path, u8 ipuser[16])

static void netiucv_callback_connrej(struct iucv_path *path, u8 *ipuser)

{

	struct iucv_connection *conn = path->private;



	fsm_event(conn->fsm, CONN_EVENT_CONN_REJ, conn);

}



static void netiucv_callback_connsusp(struct iucv_path *path, u8 ipuser[16])

static void netiucv_callback_connsusp(struct iucv_path *path, u8 *ipuser)

{

	struct iucv_connection *conn = path->private;



	fsm_event(conn->fsm, CONN_EVENT_CONN_SUS, conn);

}



static void netiucv_callback_connres(struct iucv_path *path, u8 ipuser[16])

static void netiucv_callback_connres(struct iucv_path *path, u8 *ipuser)

{

	struct iucv_connection *conn = path->private;

drivers/s390/net/smsgiucv.c

+2 −3
Original line number Diff line number Diff line
@@ -49,7 +49,7 @@ static DEFINE_SPINLOCK(smsg_list_lock); 
static LIST_HEAD(smsg_list);

static int iucv_path_connected;



static int smsg_path_pending(struct iucv_path *, u8 ipvmid[8], u8 ipuser[16]);

static int smsg_path_pending(struct iucv_path *, u8 *, u8 *);

static void smsg_message_pending(struct iucv_path *, struct iucv_message *);



static struct iucv_handler smsg_handler = {
@@ -57,8 +57,7 @@ static struct iucv_handler smsg_handler = { 
	.message_pending = smsg_message_pending,

};



static int smsg_path_pending(struct iucv_path *path, u8 ipvmid[8],

			     u8 ipuser[16])

static int smsg_path_pending(struct iucv_path *path, u8 *ipvmid, u8 *ipuser)

{

	if (strncmp(ipvmid, "*MSG    ", 8) != 0)

		return -EINVAL;

drivers/tty/hvc/hvc_iucv.c

+5 −5
Original line number Diff line number Diff line
@@ -88,8 +88,8 @@ struct iucv_tty_buffer { 
};



/* IUCV callback handler */

static	int hvc_iucv_path_pending(struct iucv_path *, u8[8], u8[16]);

static void hvc_iucv_path_severed(struct iucv_path *, u8[16]);

static	int hvc_iucv_path_pending(struct iucv_path *, u8 *, u8 *);

static void hvc_iucv_path_severed(struct iucv_path *, u8 *);

static void hvc_iucv_msg_pending(struct iucv_path *, struct iucv_message *);

static void hvc_iucv_msg_complete(struct iucv_path *, struct iucv_message *);
@@ -782,8 +782,8 @@ static int hvc_iucv_filter_connreq(u8 ipvmid[8]) 
 *

 * Locking:	struct hvc_iucv_private->lock

 */

static	int hvc_iucv_path_pending(struct iucv_path *path,

				  u8 ipvmid[8], u8 ipuser[16])

static	int hvc_iucv_path_pending(struct iucv_path *path, u8 *ipvmid,

				  u8 *ipuser)

{

	struct hvc_iucv_private *priv, *tmp;

	u8 wildcard[9] = "lnxhvc  ";
@@ -881,7 +881,7 @@ static int hvc_iucv_path_pending(struct iucv_path *path, 
 *

 * Locking:	struct hvc_iucv_private->lock

 */

static void hvc_iucv_path_severed(struct iucv_path *path, u8 ipuser[16])

static void hvc_iucv_path_severed(struct iucv_path *path, u8 *ipuser)

{

	struct hvc_iucv_private *priv = path->private;