Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 91b4dcce authored by Avihai Horon's avatar Avihai Horon Committed by Greg Kroah-Hartman
Browse files

RDMA/core: Let ib_find_gid() continue search even after empty entry 

[ Upstream commit 483d805191a23191f8294bbf9b4e94836f5d92e4 ]

Currently, ib_find_gid() will stop searching after encountering the first
empty GID table entry. This behavior is wrong since neither IB nor RoCE
spec enforce tightly packed GID tables.

For example, when a valid GID entry exists at index N, and if a GID entry
is empty at index N-1, ib_find_gid() will fail to find the valid entry.

Fix it by making ib_find_gid() continue searching even after encountering
missing entries.

Fixes: 5eb620c8 ("IB/core: Add helpers for uncached GID and P_Key searches")
Link: https://lore.kernel.org/r/e55d331b96cecfc2cf19803d16e7109ea966882d.1639055490.git.leonro@nvidia.com


Signed-off-by: default avatarAvihai Horon <avihaih@nvidia.com>
Reviewed-by: default avatarMark Zhang <markzhang@nvidia.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a09ae03e

drivers/infiniband/core/device.c

+2 −1
Original line number Diff line number Diff line
@@ -870,7 +870,8 @@ int ib_find_gid(struct ib_device *device, union ib_gid *gid, 
		for (i = 0; i < device->port_immutable[port].gid_tbl_len; ++i) {

			ret = ib_query_gid(device, port, i, &tmp_gid, NULL);

			if (ret)

				return ret;

				continue;



			if (!memcmp(&tmp_gid, gid, sizeof *gid)) {

				*port_num = port;

				if (index)