Commit 915c5857 authored Sep 23, 2015 by Karicheri, Muralidharan Committed by David S. Miller Sep 23, 2015

net: netcp: check for interface handle in netcp_module_probe()



Currently netcp_module_probe() doesn't check the return value of
of_parse_phandle() that points to the interface data for the
module and then pass the node ptr to the module which is incorrect.
Check for return value and free the intf_modpriv if there is error.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent e558b1fb

drivers/net/ethernet/ti/netcp_core.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -299,6 +299,11 @@ static int netcp_module_probe(struct netcp_device *netcp_device,
		interface = of_parse_phandle(netcp_intf->node_interface,
		module->name, 0);

		if (!interface) {
		devm_kfree(dev, intf_modpriv);
		continue;
		}

		intf_modpriv->netcp_priv = netcp_intf;
		intf_modpriv->netcp_module = module;
		list_add_tail(&intf_modpriv->intf_list,