Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 90fa9deb authored by Jean Pihet's avatar Jean Pihet Committed by Jiri Olsa
Browse files

perf tests: Add dwarf unwind test on ARM 



Adding dwarf unwind test, that setups live machine data over
the perf test thread and does the remote unwind.

Need to use -fno-optimize-sibling-calls for test compilation,
otherwise 'krava_*' function calls are optimized into jumps
and omitted from the stack unwind.

So far it was enabled only for x86.

Signed-off-by: default avatarJean Pihet <jean.pihet@linaro.org>
Reviewed-by: default avatarWill Deacon <will.deacon@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1400229672-16104-3-git-send-email-jean.pihet@linaro.org


Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
parent 3418f966

tools/perf/Makefile.perf

+1 −1
Original line number Diff line number Diff line
@@ -411,7 +411,7 @@ LIB_OBJS += $(OUTPUT)tests/code-reading.o 
LIB_OBJS += $(OUTPUT)tests/sample-parsing.o

LIB_OBJS += $(OUTPUT)tests/parse-no-sample-id-all.o

ifndef NO_DWARF_UNWIND

ifeq ($(ARCH),x86)

ifeq ($(ARCH),$(filter $(ARCH),x86 arm))

LIB_OBJS += $(OUTPUT)tests/dwarf-unwind.o

endif

endif

tools/perf/arch/arm/Makefile

+1 −0
Original line number Diff line number Diff line
@@ -5,4 +5,5 @@ endif 
ifndef NO_LIBUNWIND

LIB_OBJS += $(OUTPUT)arch/$(ARCH)/util/unwind-libunwind.o

LIB_OBJS += $(OUTPUT)arch/$(ARCH)/tests/regs_load.o

LIB_OBJS += $(OUTPUT)arch/$(ARCH)/tests/dwarf-unwind.o

endif

tools/perf/arch/arm/include/perf_regs.h

+3 −0
Original line number Diff line number Diff line
@@ -8,6 +8,9 @@ 
void perf_regs_load(u64 *regs);



#define PERF_REGS_MASK	((1ULL << PERF_REG_ARM_MAX) - 1)

#define PERF_REGS_MAX	PERF_REG_ARM_MAX

#define PERF_SAMPLE_REGS_ABI	PERF_SAMPLE_REGS_ABI_32



#define PERF_REG_IP	PERF_REG_ARM_PC

#define PERF_REG_SP	PERF_REG_ARM_SP

tools/perf/arch/arm/tests/dwarf-unwind.c

0 → 100644
+60 −0
Original line number Diff line number Diff line 
#include <string.h>

#include "perf_regs.h"

#include "thread.h"

#include "map.h"

#include "event.h"

#include "tests/tests.h"



#define STACK_SIZE 8192



static int sample_ustack(struct perf_sample *sample,

			 struct thread *thread, u64 *regs)

{

	struct stack_dump *stack = &sample->user_stack;

	struct map *map;

	unsigned long sp;

	u64 stack_size, *buf;



	buf = malloc(STACK_SIZE);

	if (!buf) {

		pr_debug("failed to allocate sample uregs data\n");

		return -1;

	}



	sp = (unsigned long) regs[PERF_REG_ARM_SP];



	map = map_groups__find(thread->mg, MAP__VARIABLE, (u64) sp);

	if (!map) {

		pr_debug("failed to get stack map\n");

		free(buf);

		return -1;

	}



	stack_size = map->end - sp;

	stack_size = stack_size > STACK_SIZE ? STACK_SIZE : stack_size;



	memcpy(buf, (void *) sp, stack_size);

	stack->data = (char *) buf;

	stack->size = stack_size;

	return 0;

}



int test__arch_unwind_sample(struct perf_sample *sample,

			     struct thread *thread)

{

	struct regs_dump *regs = &sample->user_regs;

	u64 *buf;



	buf = calloc(1, sizeof(u64) * PERF_REGS_MAX);

	if (!buf) {

		pr_debug("failed to allocate sample uregs data\n");

		return -1;

	}



	perf_regs_load(buf);

	regs->abi  = PERF_SAMPLE_REGS_ABI;

	regs->regs = buf;

	regs->mask = PERF_REGS_MASK;



	return sample_ustack(sample, thread, buf);

}

tools/perf/config/Makefile

+2 −2
Original line number Diff line number Diff line
@@ -40,11 +40,11 @@ ifeq ($(ARCH),arm64) 
  LIBUNWIND_LIBS = -lunwind -lunwind-aarch64

endif



# So far there's only x86 libdw unwind support merged in perf.

# So far there's only x86 and arm libdw unwind support merged in perf.

# Disable it on all other architectures in case libdw unwind

# support is detected in system. Add supported architectures

# to the check.

ifneq ($(ARCH),x86)

ifneq ($(ARCH),$(filter $(ARCH),x86 arm))

  NO_LIBDW_DWARF_UNWIND := 1

endif