Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 90ed4988 authored by Aristeu Rozanski's avatar Aristeu Rozanski Committed by Borislav Petkov
Browse files

e752x_edac: Fix pci_dev usage count 



In case the device 0, function 1 is not found using pci_get_device(),
pci_scan_single_device() will be used but, differently than
pci_get_device(), it allocates a pci_dev but doesn't does bump the usage
count on the pci_dev and after few module removals and loads the pci_dev
will be freed.

Signed-off-by: default avatarAristeu Rozanski <aris@redhat.com>
Reviewed-by: default avatarmark gross <mark.gross@intel.com>
Link: http://lkml.kernel.org/r/20131205153755.GL4545@redhat.com


Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
parent 8112c0cd

drivers/edac/e752x_edac.c

+3 −1
Original line number Diff line number Diff line
@@ -1182,9 +1182,11 @@ static int e752x_get_devs(struct pci_dev *pdev, int dev_idx, 
	pvt->bridge_ck = pci_get_device(PCI_VENDOR_ID_INTEL,

				pvt->dev_info->err_dev, pvt->bridge_ck);



	if (pvt->bridge_ck == NULL)

	if (pvt->bridge_ck == NULL) {

		pvt->bridge_ck = pci_scan_single_device(pdev->bus,

							PCI_DEVFN(0, 1));

		pci_dev_get(pvt->bridge_ck);

	}



	if (pvt->bridge_ck == NULL) {

		e752x_printk(KERN_ERR, "error reporting device not found:"