Commit 90989035 authored Mar 30, 2016 by Andres Freund Committed by Arnaldo Carvalho de Melo Mar 30, 2016

perf hists: Fix determination of a callchain node's childlessness



The 4b3a3212 ("perf hists browser: Support flat callchains") commit
over-aggressively tried to optimize callchain_node__init_have_children().

That lead to --tui mode not allowing to expand call chain elements if a
call chain element had only one parent. That's why --inverted callgraphs
looked halfway sane, but plain ones didn't.

Revert that individual optimization, it wasn't really related to the
rest of the commit.

Signed-off-by: Andres Freund <andres@anarazel.de>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Fixes: 4b3a3212 ("perf hists browser: Support flat callchains")
Link: http://lkml.kernel.org/r/20160330190245.GB13305@awork2.anarazel.de


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent f6343be9

tools/perf/ui/browsers/hists.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -337,7 +337,7 @@ static void callchain_node__init_have_children(struct callchain_node *node,
		chain = list_entry(node->val.next, struct callchain_list, list);
		chain->has_children = has_sibling;

		if (node->val.next != node->val.prev) {
		if (!list_empty(&node->val)) {
		chain = list_entry(node->val.prev, struct callchain_list, list);
		chain->has_children = !RB_EMPTY_ROOT(&node->rb_root);
		}