Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 90963c61 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Greg Kroah-Hartman
Browse files

ARM: dts: armadillo800eva: Split LCD mux and gpio 




[ Upstream commit 13132b3f44d3600983aceb7e9920b8ebb55a7cf8 ]

Configuration of the lcd0 pinmux group and GPIO hog for the external
GPIO mux are done using a single device node, causing the "output-high"
property to be applied to both.  This will fail for the pinmux group,
but doesn't cause any harm, as the failure is ignored silently.

However, after "pinctrl: sh-pfc: propagate errors on group config", the
failure will become fatal, leading to a broken display:

    sh-pfc e6050000.pin-controller: pin_config_group_set op failed for group 102
    sh-pfc e6050000.pin-controller: Error applying setting, reverse things back
    sh-pfc e6050000.pin-controller: failed to select default state

Move the GPIO hog to its own node to fix this.

Fixes: ffd2f9a5 ("ARM: shmobile: armadillo800eva dts: Add pinctrl and gpio-hog for lcdc0")
Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Acked-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarSimon Horman <horms+renesas@verge.net.au>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 353a7186

arch/arm/boot/dts/r8a7740-armadillo800eva.dts

+2 −0
Original line number Diff line number Diff line
@@ -266,7 +266,9 @@ 
	lcd0_pins: lcd0 {

		groups = "lcd0_data24_0", "lcd0_lclk_1", "lcd0_sync";

		function = "lcd0";

	};



	lcd0_mux {

		/* DBGMD/LCDC0/FSIA MUX */

		gpio-hog;

		gpios = <176 0>;