Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 907e0cf7 authored by Dhoat Harpal's avatar Dhoat Harpal
Browse files

soc: qcom: glink: Modify glink logging in tx_common 



Glink log in tx_common uses context based logging after
wait_for_completion_timeout. This can lead to use after free
scenerio, since transport of context can be freed during wait time.

Use glink error logging.

CRs-Fixed: 2164929
Change-Id: If66bcb7cba1772c2648c143f43a3b88af0799844
Signed-off-by: default avatarDhoat Harpal <hdhoat@codeaurora.org>
parent be27e35c

drivers/soc/qcom/glink.c

+3 −3
Original line number Diff line number Diff line 
/* Copyright (c) 2014-2017, The Linux Foundation. All rights reserved.

/* Copyright (c) 2014-2018, The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and
@@ -2994,7 +2994,7 @@ static int glink_tx_common(void *handle, void *pkt_priv, 
			if (!wait_for_completion_timeout(

					&ctx->int_req_ack_complete,

					ctx->rx_intent_req_timeout_jiffies)) {

				GLINK_ERR_CH(ctx,

				GLINK_ERR(

					"%s: Intent request ack with size: %zu not granted for lcid\n",

					__func__, size);

				ret = -ETIMEDOUT;
@@ -3014,7 +3014,7 @@ static int glink_tx_common(void *handle, void *pkt_priv, 
			if (!wait_for_completion_timeout(

					&ctx->int_req_complete,

					ctx->rx_intent_req_timeout_jiffies)) {

				GLINK_ERR_CH(ctx,

				GLINK_ERR(

					"%s: Intent request with size: %zu not granted for lcid\n",

					__func__, size);

				ret = -ETIMEDOUT;