Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d80717a authored by Haim Dreyfuss's avatar Haim Dreyfuss Committed by Emmanuel Grumbach
Browse files

iwlwifi: pcie: Fix index iteration on free_irq in MSIX mode 



In MSIX mode we iterate over the allocated interrupt vectors and
register them to an handler. In case of registration failure,
we free all the allocated irq.
we use the outer index mistakenly instead of the inner one.

Signed-off-by: default avatarHaim Dreyfuss <haim.dreyfuss@intel.com>
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
parent 9d9b21d1

drivers/net/wireless/intel/iwlwifi/pcie/trans.c

+2 −2
Original line number Diff line number Diff line
@@ -1500,8 +1500,8 @@ static int iwl_pcie_init_msix_handler(struct pci_dev *pdev, 
			IWL_ERR(trans_pcie->trans,

				"Error allocating IRQ %d\n", i);

			for (j = 0; j < i; j++)

				free_irq(trans_pcie->msix_entries[i].vector,

					 &trans_pcie->msix_entries[i]);

				free_irq(trans_pcie->msix_entries[j].vector,

					 &trans_pcie->msix_entries[j]);

			pci_disable_msix(pdev);

			return ret;

		}