Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d4a3297 authored by Jason Gunthorpe's avatar Jason Gunthorpe Committed by Greg Kroah-Hartman
Browse files

RMDA/cm: Fix missing ib_cm_destroy_id() in ib_cm_insert_listen() 

commit c14dfddbd869bf0c2bafb7ef260c41d9cebbcfec upstream.

The algorithm pre-allocates a cm_id since allocation cannot be done while
holding the cm.lock spinlock, however it doesn't free it on one error
path, leading to a memory leak.

Fixes: 067b171b ("IB/cm: Share listening CM IDs")
Link: https://lore.kernel.org/r/20200221152023.GA8680@ziepe.ca


Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3c4fef9c

drivers/infiniband/core/cm.c

+1 −0
Original line number Diff line number Diff line
@@ -1073,6 +1073,7 @@ struct ib_cm_id *ib_cm_insert_listen(struct ib_device *device, 
			/* Sharing an ib_cm_id with different handlers is not

			 * supported */

			spin_unlock_irqrestore(&cm.lock, flags);

			ib_destroy_cm_id(cm_id);

			return ERR_PTR(-EINVAL);

		}

		atomic_inc(&cm_id_priv->refcount);