Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d3b33f6 authored by Rusty Russell's avatar Rusty Russell Committed by Linus Torvalds
Browse files

[PATCH] Remove MODULE_PARM 



MODULE_PARM was actually breaking: recent gcc version optimize them out as
unused.  It's time to replace the last users, which are generally in the
most unloved drivers anyway.

Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent c721bcce

Documentation/networking/ray_cs.txt

+1 −1
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ the essid= string parameter is available via the kernel command line. 
This will change after the method of sorting out parameters for all

the PCMCIA drivers is agreed upon.  If you must have a built in driver

with nondefault parameters, they can be edited in

/usr/src/linux/drivers/net/pcmcia/ray_cs.c.  Searching for MODULE_PARM

/usr/src/linux/drivers/net/pcmcia/ray_cs.c.  Searching for module_param

will find them all.



Information on card services is available at:

Documentation/sound/oss/Introduction

+1 −1
Original line number Diff line number Diff line
@@ -69,7 +69,7 @@ are available, for example IRQ, address, DMA. 


Warning, the options for different cards sometime use different names 

for the same or a similar feature (dma1= versus dma16=).  As a last 

resort, inspect the code (search for MODULE_PARM).

resort, inspect the code (search for module_param).



Notes:

Documentation/sound/oss/cs46xx

+8 −8
Original line number Diff line number Diff line
@@ -88,7 +88,7 @@ parameters. for a copy email: twoller@crystal.cirrus.com 


MODULE_PARMS definitions

------------------------

MODULE_PARM(defaultorder, "i");

module_param(defaultorder, ulong, 0);

defaultorder=N

where N is a value from 1 to 12

The buffer order determines the size of the dma buffer for the driver.
@@ -98,18 +98,18 @@ to not underrun the dma buffer as easily. As default, use 32k (order=3) 
rather than 64k as some of the games work more responsively.

(2^N) * PAGE_SIZE = allocated buffer size



MODULE_PARM(cs_debuglevel, "i");

MODULE_PARM(cs_debugmask, "i");

module_param(cs_debuglevel, ulong, 0644);

module_param(cs_debugmask, ulong, 0644);

cs_debuglevel=N

cs_debugmask=0xMMMMMMMM

where N is a value from 0 (no debug printfs), to 9 (maximum)

0xMMMMMMMM is a debug mask corresponding to the CS_xxx bits (see driver source).



MODULE_PARM(hercules_egpio_disable, "i");

module_param(hercules_egpio_disable, ulong, 0);

hercules_egpio_disable=N

where N is a 0 (enable egpio), or a 1 (disable egpio support)



MODULE_PARM(initdelay, "i");

module_param(initdelay, ulong, 0);

initdelay=N

This value is used to determine the millescond delay during the initialization

code prior to powering up the PLL.  On laptops this value can be used to
@@ -118,19 +118,19 @@ system is booted under battery power then the mdelay()/udelay() functions fail t 
properly delay the required time.  Also, if the system is booted under AC power

and then the power removed, the mdelay()/udelay() functions will not delay properly.

 

MODULE_PARM(powerdown, "i");

module_param(powerdown, ulong, 0);

powerdown=N

where N is 0 (disable any powerdown of the internal blocks) or 1 (enable powerdown)





MODULE_PARM(external_amp, "i");

module_param(external_amp, bool, 0);

external_amp=1

if N is set to 1, then force enabling the EAPD support in the primary AC97 codec.

override the detection logic and force the external amp bit in the AC97 0x26 register

to be reset (0).  EAPD should be 0 for powerup, and 1 for powerdown.  The VTB Santa Cruz

card has inverted logic, so there is a special function for these cards.



MODULE_PARM(thinkpad, "i");

module_param(thinkpad, bool, 0);

thinkpad=1

if N is set to 1, then force enabling the clkrun functionality.

Currently, when the part is being used, then clkrun is disabled for the entire system,

arch/ppc/8xx_io/cs4218_tdm.c

+5 −5
Original line number Diff line number Diff line
@@ -126,11 +126,11 @@ static int numReadBufs = 4, readbufSize = 32; 
*/

static volatile cbd_t	*rx_base, *rx_cur, *tx_base, *tx_cur;



MODULE_PARM(catchRadius, "i");

MODULE_PARM(numBufs, "i");

MODULE_PARM(bufSize, "i");

MODULE_PARM(numreadBufs, "i");

MODULE_PARM(readbufSize, "i");

module_param(catchRadius, int, 0);

module_param(numBufs, int, 0);

module_param(bufSize, int, 0);

module_param(numreadBufs, int, 0);

module_param(readbufSize, int, 0);



#define arraysize(x)	(sizeof(x)/sizeof(*(x)))

#define le2be16(x)	(((x)<<8 & 0xff00) | ((x)>>8 & 0x00ff))

drivers/block/ataflop.c

+2 −2
Original line number Diff line number Diff line
@@ -271,7 +271,7 @@ unsigned char *DMABuffer; /* buffer for writes */ 
static unsigned long PhysDMABuffer;   /* physical address */



static int UseTrackbuffer = -1;		  /* Do track buffering? */

MODULE_PARM(UseTrackbuffer, "i");

module_param(UseTrackbuffer, int, 0);



unsigned char *TrackBuffer;			  /* buffer for reads */

static unsigned long PhysTrackBuffer; /* physical address */
@@ -296,7 +296,7 @@ static int MotorOn = 0, MotorOffTrys; 
static int IsFormatting = 0, FormatError;



static int UserSteprate[FD_MAX_UNITS] = { -1, -1 };

MODULE_PARM(UserSteprate, "1-" __MODULE_STRING(FD_MAX_UNITS) "i");

module_param_array(UserSteprate, int, NULL, 0);



/* Synchronization of FDC access. */

static volatile int fdc_busy = 0;