Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d091242 authored by Daniel Mack's avatar Daniel Mack Committed by Takashi Iwai
Browse files

ALSA: usb-audio: fix return values 



-1 is not a good return value as it means -EPERM, "not permitted".
Choose -ENOTSUPP instead, which is what the code really wants to tell
its callers.

Signed-off-by: default avatarDaniel Mack <daniel@caiaq.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 74754f97

sound/usb/format.c

+2 −2
Original line number Diff line number Diff line
@@ -408,7 +408,7 @@ int snd_usb_parse_audio_format(struct snd_usb_audio *chip, struct audioformat *f 
		snd_printd(KERN_INFO "%d:%u:%d : format type %d is not supported yet\n",

			   chip->dev->devnum, fp->iface, fp->altsetting,

			   fmt->bFormatType);

		return -1;

		return -ENOTSUPP;

	}

	fp->fmt_type = fmt->bFormatType;

	if (err < 0)
@@ -424,7 +424,7 @@ int snd_usb_parse_audio_format(struct snd_usb_audio *chip, struct audioformat *f 
		if (fmt->bFormatType == UAC_FORMAT_TYPE_I &&

		    fp->rates != SNDRV_PCM_RATE_48000 &&

		    fp->rates != SNDRV_PCM_RATE_96000)

			return -1;

			return -ENOTSUPP;

	}

#endif

	return 0;