Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8cff6c64 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

greybus: connection: simplify connection-creation interface 



Simplify the exported generic interface for creating dynamic
connections.

Since all driver connections will have a bundle we can drop the
redundant interface parameter.

Reviewed-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent e4c16f8b

drivers/staging/greybus/connection.c

+3 −3
Original line number Diff line number Diff line
@@ -225,10 +225,10 @@ gb_connection_create_control(struct gb_interface *intf) 
}



struct gb_connection *

gb_connection_create_dynamic(struct gb_interface *intf,

					struct gb_bundle *bundle,

					u16 cport_id)

gb_connection_create_dynamic(struct gb_bundle *bundle, u16 cport_id)

{

	struct gb_interface *intf = bundle->intf;



	return gb_connection_create(intf->hd, -1, intf, bundle, cport_id);

}

EXPORT_SYMBOL_GPL(gb_connection_create_dynamic);

drivers/staging/greybus/connection.h

+2 −2
Original line number Diff line number Diff line
@@ -58,8 +58,8 @@ struct gb_connection { 
struct gb_connection *gb_connection_create_static(struct gb_host_device *hd,

				u16 hd_cport_id);

struct gb_connection *gb_connection_create_control(struct gb_interface *intf);

struct gb_connection *gb_connection_create_dynamic(struct gb_interface *intf,

				struct gb_bundle *bundle, u16 cport_id);

struct gb_connection *gb_connection_create_dynamic(struct gb_bundle *bundle,

				u16 cport_id);

void gb_connection_destroy(struct gb_connection *connection);



static inline bool gb_connection_is_static(struct gb_connection *connection)

drivers/staging/greybus/legacy.c

+1 −2
Original line number Diff line number Diff line
@@ -153,8 +153,7 @@ static int legacy_probe(struct gb_bundle *bundle, 
	for (i = 0; i < data->num_cports; ++i) {

		cport_desc = &bundle->cport_desc[i];



		connection = gb_connection_create_dynamic(bundle->intf,

						bundle,

		connection = gb_connection_create_dynamic(bundle,

						le16_to_cpu(cport_desc->id));

		if (!connection)

			goto err_connections_destroy;