Commit 8cde3e44 authored Dec 08, 2015 by Arnd Bergmann Committed by David S. Miller Dec 08, 2015

net: fsl: avoid 64-bit warning on pq_mdio

The pq_mdio driver can now be built for ARM64, where we get a format
string warning:

drivers/net/ethernet/freescale/fsl_pq_mdio.c: In function 'fsl_pq_mdio_probe':
drivers/net/ethernet/freescale/fsl_pq_mdio.c:467:25: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long int' [-Wformat=]

The argument is an implicit ptrdiff_t from the subtraction of two pointers,
so we should use the %z format string modifier to make this work on 64-bit
architectures.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: fe761bcb ("net: fsl: expands dependencies of NET_VENDOR_FREESCALE")
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 90186af4

drivers/net/ethernet/freescale/fsl_pq_mdio.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -464,7 +464,7 @@ static int fsl_pq_mdio_probe(struct platform_device *pdev)
		* address). Print error message but continue anyway.
		*/
		if ((void *)tbipa > priv->map + resource_size(&res) - 4)
		dev_err(&pdev->dev, "invalid register map (should be at least 0x%04x to contain TBI address)\n",
		dev_err(&pdev->dev, "invalid register map (should be at least 0x%04zx to contain TBI address)\n",
		((void *)tbipa - priv->map) + 4);

		iowrite32be(be32_to_cpup(prop), tbipa);