Commit 8cc085c7 authored Dec 21, 2007 by Al Viro Committed by Jeff Garzik Dec 22, 2007

typhoon: memory corruptor on big-endian if TSO is enabled



txlo_dma_addr should be host-endian; we pass it to typhoon_tso_fill(),
which does arithmetics on it, converts to l-e and passes it to card.
Unfortunately, we forgot le32_to_cpu() when initializing it from
face->txLoAddr, which sits in shared memory and is little-endian.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent 8a5ed9ef

drivers/net/typhoon.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1320,7 +1320,7 @@ typhoon_init_interface(struct typhoon *tp)
		tp->txLoRing.writeRegister = TYPHOON_REG_TX_LO_READY;
		tp->txHiRing.writeRegister = TYPHOON_REG_TX_HI_READY;

		tp->txlo_dma_addr = iface->txLoAddr;
		tp->txlo_dma_addr = le32_to_cpu(iface->txLoAddr);
		tp->card_state = Sleeping;
		smp_wmb();