Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8bdfac4c authored by Praveen Kumar Sirisilla's avatar Praveen Kumar Sirisilla Committed by Madan Mohan Koyyalamudi
Browse files

SS Code changes to pass the code review inspection [UMAC} changes 

The patch modifies UMAC code to pass the SS code review inspection

Change-Id: Id527265f0e3ed33a03ab242a3e0afec069487269
CRs-Fixed: 555476
parent 4da2c3a5

CORE/BAP/src/bapApiLinkCntl.c

+1 −1
Original line number Diff line number Diff line
@@ -1572,7 +1572,7 @@ WLAN_BAPLogicalLinkDisconnect 
    /* Derive logical link index from handle */

    log_link_index = ((pBapHCILogLinkDisconnect->log_link_handle) >> 8);



    if( log_link_index > WLANBAP_MAX_LOG_LINKS )

    if( log_link_index >= WLANBAP_MAX_LOG_LINKS )

    {

       VOS_TRACE( VOS_MODULE_ID_BAP, VOS_TRACE_LEVEL_ERROR, 

                  "Critical error: Invalid input parameter on %s",

CORE/MAC/src/pe/lim/limAssocUtils.c

+3 −3
Original line number Diff line number Diff line
@@ -1825,7 +1825,7 @@ limPopulatePeerRateSet(tpAniSirGlobal pMac, 
    isArate = 0;



    /* copy operational rate set from psessionEntry */

    if ( psessionEntry->rateSet.numRates < SIR_MAC_RATESET_EID_MAX )

    if ( psessionEntry->rateSet.numRates <= SIR_MAC_RATESET_EID_MAX )

    {

        palCopyMemory(pMac->hHdd,(tANI_U8 *)tempRateSet.rate,(tANI_U8*)(psessionEntry->rateSet.rate), psessionEntry->rateSet.numRates);

        tempRateSet.numRates = psessionEntry->rateSet.numRates;
@@ -1838,7 +1838,7 @@ limPopulatePeerRateSet(tpAniSirGlobal pMac, 
    if (psessionEntry->dot11mode == WNI_CFG_DOT11_MODE_11G)

    {



        if (psessionEntry->extRateSet.numRates < SIR_MAC_RATESET_EID_MAX)

        if (psessionEntry->extRateSet.numRates <= SIR_MAC_RATESET_EID_MAX)

        {

            palCopyMemory(pMac->hHdd,(tANI_U8 *)tempRateSet2.rate, (tANI_U8*)(psessionEntry->extRateSet.rate), psessionEntry->extRateSet.numRates);

            tempRateSet2.numRates = psessionEntry->extRateSet.numRates;
@@ -1850,7 +1850,7 @@ limPopulatePeerRateSet(tpAniSirGlobal pMac, 
    }

    else

        tempRateSet2.numRates = 0;

    if ((tempRateSet.numRates + tempRateSet2.numRates) > 12)

    if ((tempRateSet.numRates + tempRateSet2.numRates) > SIR_MAC_RATESET_EID_MAX)

    {

        //we are in big trouble

        limLog(pMac, LOGP, FL("more than 12 rates in CFG"));

CORE/MAC/src/pe/lim/limProcessTdls.c

+1 −0
Original line number Diff line number Diff line
@@ -2521,6 +2521,7 @@ limTdlsPopulateMatchingRateSet(tpAniSirGlobal pMac, 
    {

        /// Could not get rateset from CFG. Log error.

        limLog(pMac, LOGP, FL("could not retrieve rateset"));

        val = 0;

    }

    tempRateSet.numRates = val;

CORE/MAC/src/pe/pmm/pmmApi.c

+6 −4
Original line number Diff line number Diff line
@@ -320,10 +320,6 @@ void pmmExitBmpsRequestHandler(tpAniSirGlobal pMac, tpExitBmpsInfo pExitBmpsInfo 


    tPmmState origState = pMac->pmm.gPmmState;



#ifdef FEATURE_WLAN_DIAG_SUPPORT 

    limDiagEventReport(pMac, WLAN_PE_DIAG_EXIT_BMPS_REQ_EVENT, peGetValidPowerSaveSession(pMac), 0, (tANI_U16)pExitBmpsInfo->exitBmpsReason);

#endif //FEATURE_WLAN_DIAG_SUPPORT



    if (NULL == pExitBmpsInfo)

    {

        respStatus = eSIR_SME_BMPS_REQ_REJECT;
@@ -331,6 +327,12 @@ void pmmExitBmpsRequestHandler(tpAniSirGlobal pMac, tpExitBmpsInfo pExitBmpsInfo 
        goto failure;

    }



#ifdef FEATURE_WLAN_DIAG_SUPPORT

    limDiagEventReport(pMac, WLAN_PE_DIAG_EXIT_BMPS_REQ_EVENT,

                       peGetValidPowerSaveSession(pMac), 0,

                       (tANI_U16)pExitBmpsInfo->exitBmpsReason);

#endif //FEATURE_WLAN_DIAG_SUPPORT



    /* PMC is not aware of Background scan, which is done in

     * BMPS mode while Nth Beacon is delivered. Essentially, PMC

     * can request the device to get out of power-save while

CORE/SME/src/QoS/sme_Qos.c

+12 −1
Original line number Diff line number Diff line
@@ -4389,7 +4389,7 @@ eHalStatus sme_QosProcessReassocReqEv(tpAniSirGlobal pMac, v_U8_t sessionId, voi 
eHalStatus sme_QosProcessReassocSuccessEv(tpAniSirGlobal pMac, v_U8_t sessionId, void * pEvent_info)

{



   tCsrRoamSession *pCsrRoamSession = CSR_GET_SESSION( pMac, sessionId );

   tCsrRoamSession *pCsrRoamSession = NULL;

   sme_QosSessionInfo *pSession;

   sme_QosACInfo *pACInfo;

   sme_QosEdcaAcType ac, ac_index;
@@ -4403,6 +4403,17 @@ eHalStatus sme_QosProcessReassocSuccessEv(tpAniSirGlobal pMac, v_U8_t sessionId, 
             "%s: %d: invoked on session %d",

             __func__, __LINE__,

             sessionId);



   if (CSR_ROAM_SESSION_MAX <= sessionId) {

       VOS_TRACE(VOS_MODULE_ID_SME, VOS_TRACE_LEVEL_ERROR,

                "%s: %d: invoked on session %d",

                __func__, __LINE__,

                sessionId);

       return status;

   }



   pCsrRoamSession = CSR_GET_SESSION( pMac, sessionId );



   pSession = &sme_QosCb.sessionInfo[sessionId];

   // our pending reassociation has completed

   // we can allow powersave