Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8b7a4544 authored by Steve French's avatar Steve French
Browse files

CIFS: session servername can't be null 



remove impossible check

Pointed out by Coverity (CID 115422)

Signed-off-by: default avatarSteve French <smfrench@gmail.com>
Reviewed-by: default avatarJeff Layton <jlayton@samba.org>
parent c85c35f8

fs/cifs/cifsencrypt.c

+5 −1
Original line number Diff line number Diff line 
/*

 *   fs/cifs/cifsencrypt.c

 *

 *   Encryption and hashing operations relating to NTLM, NTLMv2.  See MS-NLMP

 *   for more detailed information

 *

 *   Copyright (C) International Business Machines  Corp., 2005,2013

 *   Author(s): Steve French (sfrench@us.ibm.com)

 *
@@ -515,7 +518,8 @@ static int calc_ntlmv2_hash(struct cifs_ses *ses, char *ntlmv2_hash, 
				 __func__);

			return rc;

		}

	} else if (ses->serverName) {

	} else {

		/* We use ses->serverName if no domain name available */

		len = strlen(ses->serverName);



		server = kmalloc(2 + (len * 2), GFP_KERNEL);