Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8b2b9c1a authored by Akinobu Mita's avatar Akinobu Mita Committed by Ingo Molnar
Browse files

x86, intel_cacheinfo: fix use-after-free cache_kobject 



This avoids calling kobject_uevent() with cache_kobject that has
already been deallocated in an error path.

Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 2b7207a6

arch/x86/kernel/cpu/intel_cacheinfo.c

+3 −4
Original line number Diff line number Diff line
@@ -780,15 +780,14 @@ static int __cpuinit cache_add_dev(struct sys_device * sys_dev) 
			}

			kobject_put(per_cpu(cache_kobject, cpu));

			cpuid4_cache_sysfs_exit(cpu);

			break;

			return retval;

		}

		kobject_uevent(&(this_object->kobj), KOBJ_ADD);

	}

	if (!retval)

	cpu_set(cpu, cache_dev_map);



	kobject_uevent(per_cpu(cache_kobject, cpu), KOBJ_ADD);

	return retval;

	return 0;

}



static void __cpuinit cache_remove_dev(struct sys_device * sys_dev)