Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8aeea031 authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Jens Axboe
Browse files

mtip32xx: use formatting capability of kthread_create_on_node 



kthread_create_on_node takes format+args, so there's no need to do the
pretty-printing in advance. Moreover, "mtip_svc_thd_99" (including its
'\0') only just fits in 16 bytes, so if index could ever go above 99
we'd have a stack buffer overflow.

Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: default avatarJeff Moyer <jmoyer@redhat.com>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent 604e8c8d

drivers/block/mtip32xx/mtip32xx.c

+2 −4
Original line number Diff line number Diff line
@@ -3810,7 +3810,6 @@ static int mtip_block_initialize(struct driver_data *dd) 
	sector_t capacity;

	unsigned int index = 0;

	struct kobject *kobj;

	unsigned char thd_name[16];



	if (dd->disk)

		goto skip_create_disk; /* hw init done, before rebuild */
@@ -3958,10 +3957,9 @@ static int mtip_block_initialize(struct driver_data *dd) 
	}



start_service_thread:

	sprintf(thd_name, "mtip_svc_thd_%02d", index);

	dd->mtip_svc_handler = kthread_create_on_node(mtip_service_thread,

						dd, dd->numa_node, "%s",

						thd_name);

						dd, dd->numa_node,

						"mtip_svc_thd_%02d", index);



	if (IS_ERR(dd->mtip_svc_handler)) {

		dev_err(&dd->pdev->dev, "service thread failed to start\n");