Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8a826a34 authored by Boris Brezillon's avatar Boris Brezillon Committed by Herbert Xu
Browse files

crypto: testmgr - test IV value after a cipher operation 



The crypto drivers are supposed to update the IV passed to the crypto
request before calling the completion callback.
Test for the IV value before considering the test as successful.

Signed-off-by: default avatarBoris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent d6ba06b8

crypto/testmgr.c

+11 −1
Original line number Diff line number Diff line
@@ -1034,12 +1034,22 @@ static int __test_skcipher(struct crypto_skcipher *tfm, int enc, 


		q = data;

		if (memcmp(q, template[i].result, template[i].rlen)) {

			pr_err("alg: skcipher%s: Test %d failed on %s for %s\n",

			pr_err("alg: skcipher%s: Test %d failed (invalid result) on %s for %s\n",

			       d, j, e, algo);

			hexdump(q, template[i].rlen);

			ret = -EINVAL;

			goto out;

		}



		if (template[i].iv_out &&

		    memcmp(iv, template[i].iv_out,

			   crypto_skcipher_ivsize(tfm))) {

			pr_err("alg: skcipher%s: Test %d failed (invalid output IV) on %s for %s\n",

			       d, j, e, algo);

			hexdump(iv, crypto_skcipher_ivsize(tfm));

			ret = -EINVAL;

			goto out;

		}

	}



	j = 0;

crypto/testmgr.h

+1 −0
Original line number Diff line number Diff line
@@ -67,6 +67,7 @@ struct hash_testvec { 
struct cipher_testvec {

	char *key;

	char *iv;

	char *iv_out;

	char *input;

	char *result;

	unsigned short tap[MAX_TAP];