Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 891c31e1 authored by Vishal Verma's avatar Vishal Verma Committed by Greg Kroah-Hartman
Browse files

libnvdimm, btt: fix btt_rw_page not returning errors 



commit c13c43d54f2c6a3be1c675766778ac1ad8dfbfcc upstream.

btt_rw_page was not propagating errors frm btt_do_bvec, resulting in any
IO errors via the rw_page path going unnoticed. the pmem driver recently
fixed this in e10624f8 pmem: fail io-requests to known bad blocks
but same problem in BTT went neglected.

Fixes: 5212e11f ("nd_btt: atomic sector updates")
Cc: Toshi Kani <toshi.kani@hpe.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: default avatarVishal Verma <vishal.l.verma@intel.com>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e82672f4

drivers/nvdimm/btt.c

+6 −3
Original line number Diff line number Diff line
@@ -1203,10 +1203,13 @@ static int btt_rw_page(struct block_device *bdev, sector_t sector, 
		struct page *page, bool is_write)

{

	struct btt *btt = bdev->bd_disk->private_data;

	int rc;



	btt_do_bvec(btt, NULL, page, PAGE_SIZE, 0, is_write, sector);

	rc = btt_do_bvec(btt, NULL, page, PAGE_SIZE, 0, is_write, sector);

	if (rc == 0)

		page_endio(page, is_write, 0);

	return 0;



	return rc;

}