Commit 88e3c76a authored Oct 16, 2014 by Tomi Valkeinen

OMAPDSS: HDMI: fix PLL GO bit handling

The PLL settings are committed by setting GO bit, which is then cleared
by the HW when the settings have been taken into use.

The current PLL code handles this wrong: instead of waiting for the bit
to be cleared, it waits for the bit to be set. Usually, the bit is
always set, as the CPU has just set it before. However, if the CPU takes
enough time between setting the GO bit and checking it, the HW may
already have cleared the bit and this leads to timeout error.

Fix the wait to check the bit properly.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

parent 13a0c40a

drivers/video/fbdev/omap2/dss/hdmi_pll.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -144,8 +144,8 @@ static int hdmi_pll_config(struct hdmi_pll_data *pll)

		/* wait for bit change */
		if (hdmi_wait_for_bit_change(pll->base, PLLCTRL_PLL_GO,
		0, 0, 1) != 1) {
		DSSERR("PLL GO bit not set\n");
		0, 0, 0) != 0) {
		DSSERR("PLL GO bit not clearing\n");
		return -ETIMEDOUT;
		}