Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8895ef4e authored by Ding Pixel's avatar Ding Pixel Committed by Greg Kroah-Hartman
Browse files

drm/amdgpu: check ring being ready before using 




[ Upstream commit c5f21c9f878b8dcd54d0b9739c025ca73cb4c091 ]

Return success when the ring is properly initialized, otherwise return
failure.

Tonga SRIOV VF doesn't have UVD and VCE engines, the initialization of
these IPs is bypassed. The system crashes if application submit IB to
their rings which are not ready to use. It could be a common issue if
IP having ring buffer is disabled for some reason on specific ASIC, so
it should check the ring being ready to use.

Bug: amdgpu_test crashes system on Tonga VF.

Signed-off-by: default avatarDing Pixel <Pixel.Ding@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarSasha Levin <alexander.levin@verizon.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e5a2ba9a

drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

+7 −0
Original line number Diff line number Diff line
@@ -83,6 +83,13 @@ int amdgpu_cs_get_ring(struct amdgpu_device *adev, u32 ip_type, 
		}

		break;

	}



	if (!(*out_ring && (*out_ring)->adev)) {

		DRM_ERROR("Ring %d is not initialized on IP %d\n",

			  ring, ip_type);

		return -EINVAL;

	}



	return 0;

}