Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 888155bb authored by Dan Carpenter's avatar Dan Carpenter Committed by Dave Airlie
Browse files

vmwgfx: return an -EFAULT if copy_to_user() fails 



copy_to_user() returns the number of bytes remaining to be copied, but
we want to return a negative error code here.  I fixed a couple of these
last year, but I missed this one.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 77b67063

drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c

+2 −0
Original line number Diff line number Diff line
@@ -110,6 +110,8 @@ int vmw_get_cap_3d_ioctl(struct drm_device *dev, void *data, 
	memcpy_fromio(bounce, &fifo_mem[SVGA_FIFO_3D_CAPS], size);



	ret = copy_to_user(buffer, bounce, size);

	if (ret)

		ret = -EFAULT;

	vfree(bounce);



	if (unlikely(ret != 0))