Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 87a6b9bd authored by Andrei Emeltchenko's avatar Andrei Emeltchenko Committed by Marcel Holtmann
Browse files

Bluetooth: h5: Do not initialize Configuration field 



Initializing Configuration field in H5 Config message to 0x01 gives
wrong impression that the value is used and needed. Later on the whole
field is rewritten with h5_cfg_field().

Signed-off-by: default avatarAndrei Emeltchenko <andrei.emeltchenko@intel.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent c3838353

drivers/bluetooth/hci_h5.c

+2 −2
Original line number Diff line number Diff line
@@ -123,7 +123,7 @@ static u8 h5_cfg_field(struct h5 *h5) 
static void h5_timed_event(unsigned long arg)

{

	const unsigned char sync_req[] = { 0x01, 0x7e };

	unsigned char conf_req[] = { 0x03, 0xfc, 0x01 };

	unsigned char conf_req[3] = { 0x03, 0xfc };

	struct hci_uart *hu = (struct hci_uart *)arg;

	struct h5 *h5 = hu->priv;

	struct sk_buff *skb;
@@ -281,7 +281,7 @@ static void h5_handle_internal_rx(struct hci_uart *hu) 
	struct h5 *h5 = hu->priv;

	const unsigned char sync_req[] = { 0x01, 0x7e };

	const unsigned char sync_rsp[] = { 0x02, 0x7d };

	unsigned char conf_req[] = { 0x03, 0xfc, 0x01 };

	unsigned char conf_req[3] = { 0x03, 0xfc };

	const unsigned char conf_rsp[] = { 0x04, 0x7b };

	const unsigned char wakeup_req[] = { 0x05, 0xfa };

	const unsigned char woken_req[] = { 0x06, 0xf9 };