Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 878ede02 authored by Surajit Podder's avatar Surajit Podder Committed by Shivendra Kakrania
Browse files

msm: vidc: BUG_ON before killing session on timeout 



BUG_ON before killing session on timeout to ensure
firmware session state is maintained in ram dumps.

Change-Id: Ib011c7127675fae1040973a2085bde6283d5df1a
Signed-off-by: default avatarSurajit Podder <spodder@codeaurora.org>
Signed-off-by: default avatarShivendra Kakrania <shiven@codeaurora.org>
parent 12e9e930

drivers/media/platform/msm/vidc/msm_vidc_common.c

+2 −2
Original line number Diff line number Diff line
@@ -1078,12 +1078,12 @@ static int wait_for_sess_signal_receipt(struct msm_vidc_inst *inst, 
	if (!rc) {

		dprintk(VIDC_ERR, "Wait interrupted or timed out: %d\n",

				SESSION_MSG_INDEX(cmd));

		msm_comm_kill_session(inst);

		call_hfi_op(hdev, flush_debug_queue, hdev->hfi_device_data);

		dprintk(VIDC_ERR,

			"sess resp timeout can potentially crash the system\n");

		msm_comm_print_debug_info(inst);

		msm_vidc_handle_hw_error(inst->core);

		msm_comm_kill_session(inst);

		rc = -EIO;

	} else {

		rc = 0;
@@ -4163,13 +4163,13 @@ int msm_comm_try_get_prop(struct msm_vidc_inst *inst, enum hal_property ptype, 
			__func__, inst,

			SESSION_MSG_INDEX(HAL_SESSION_PROPERTY_INFO));

		inst->state = MSM_VIDC_CORE_INVALID;

		msm_comm_kill_session(inst);

		call_hfi_op(hdev, flush_debug_queue, hdev->hfi_device_data);

		dprintk(VIDC_ERR,

			"SESS_PROP timeout can potentially crash the system\n");

		msm_comm_print_debug_info(inst);



		msm_vidc_handle_hw_error(inst->core);

		msm_comm_kill_session(inst);

		rc = -ETIMEDOUT;

		goto exit;

	} else {