Commit 86138a49 authored Apr 11, 2017 by Mahesh Bandewar Committed by Greg Kroah-Hartman Mar 24, 2018

bonding: handle link transition from FAIL to UP correctly




[ Upstream commit fb9eb899a6dc663e4a2deed9af2ac28f507d0ffb ]

When link transitions from LINK_FAIL to LINK_UP, the commit phase is
not called. This leads to an erroneous state causing slave-link state to
get stuck in "going down" state while its speed and duplex are perfectly
fine. This issue is a side-effect of splitting link-set into propose and
commit phases introduced by de77ecd4ef02 ("bonding: improve link-status
update in mii-monitoring")

This patch fixes these issues by calling commit phase whenever link
state change is proposed.

Fixes: de77ecd4ef02 ("bonding: improve link-status update in mii-monitoring")
Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 09604c91

drivers/net/bonding/bond_main.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -2067,6 +2067,7 @@ static int bond_miimon_inspect(struct bonding *bond)
		(bond->params.downdelay - slave->delay) *
		bond->params.miimon,
		slave->dev->name);
		commit++;
		continue;
		}

		@@ -2104,7 +2105,7 @@ static int bond_miimon_inspect(struct bonding *bond)
		(bond->params.updelay - slave->delay) *
		bond->params.miimon,
		slave->dev->name);

		commit++;
		continue;
		}