Commit 85eae82a authored Oct 15, 2012 by Paul E. McKenney Committed by Linus Torvalds Oct 16, 2012

printk: Fix scheduling-while-atomic problem in console_cpu_notify()

The console_cpu_notify() function runs with interrupts disabled in the
CPU_DYING case. It therefore cannot block, for example, as will happen
when it calls console_lock(). Therefore, remove the CPU_DYING leg of
the switch statement to avoid this problem.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 75fa29c7

kernel/printk.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1890,7 +1890,6 @@ static int __cpuinit console_cpu_notify(struct notifier_block *self,
		switch (action) {
		case CPU_ONLINE:
		case CPU_DEAD:
		case CPU_DYING:
		case CPU_DOWN_FAILED:
		case CPU_UP_CANCELED:
		console_lock();