Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 85d898bf authored by Daniel Kurtz's avatar Daniel Kurtz Committed by Inki Dae
Browse files

drm/exynos: Fix (more) freeing issues in exynos_drm_drv.c 



The following commit [0] fixed a use-after-free, but left the subdrv open
in the error path.

[0] commit 6ca605f7
drm/exynos: Fix freeing issues in exynos_drm_drv.c

Signed-off-by: default avatarDaniel Kurtz <djkurtz@chromium.org>
Acked-by: default avatarSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: default avatarInki Dae <inki.dae@samsung.com>
parent 27410e82

drivers/gpu/drm/exynos/exynos_drm_drv.c

+7 −3
Original line number Diff line number Diff line
@@ -172,20 +172,24 @@ static int exynos_drm_open(struct drm_device *dev, struct drm_file *file) 


	ret = exynos_drm_subdrv_open(dev, file);

	if (ret)

		goto out;

		goto err_file_priv_free;



	anon_filp = anon_inode_getfile("exynos_gem", &exynos_drm_gem_fops,

					NULL, 0);

	if (IS_ERR(anon_filp)) {

		ret = PTR_ERR(anon_filp);

		goto out;

		goto err_subdrv_close;

	}



	anon_filp->f_mode = FMODE_READ | FMODE_WRITE;

	file_priv->anon_filp = anon_filp;



	return ret;

out:



err_subdrv_close:

	exynos_drm_subdrv_close(dev, file);



err_file_priv_free:

	kfree(file_priv);

	file->driver_priv = NULL;

	return ret;