Commit 8582bbfb authored Jul 17, 2018 by Colin Ian King Committed by Greg Kroah-Hartman Jul 25, 2018

ipv6: fix useless rol32 call on hash



[ Upstream commit 169dc027fb02492ea37a0575db6a658cf922b854 ]

The rol32 call is currently rotating hash but the rol'd value is
being discarded. I believe the current code is incorrect and hash
should be assigned the rotated value returned from rol32.

Thanks to David Lebrun for spotting this.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 79870c6c

include/net/ipv6.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -794,7 +794,7 @@ static inline __be32 ip6_make_flowlabel(struct net net, struct sk_buff skb,
		* to minimize possbility that any useful information to an
		* attacker is leaked. Only lower 20 bits are relevant.
		*/
		rol32(hash, 16);
		hash = rol32(hash, 16);

		flowlabel = (__force __be32)hash & IPV6_FLOWLABEL_MASK;