Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 852bcafb authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller
Browse files

net: bcmgenet: Remove duplicate test for tx_coalesce_usecs_high 



We were checking twice for ec->tx_coalesce_usecs_high, remove the
duplicate test.

Reported-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Reported-by: default avatar <kbuild-all@01.org>
Fixes: 2f913070 ("net: bcmgenet: Implement TX coalescing control knobs")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f9b99582

drivers/net/ethernet/broadcom/genet/bcmgenet.c

+1 −2
Original line number Diff line number Diff line
@@ -608,8 +608,7 @@ static int bcmgenet_set_coalesce(struct net_device *dev, 
	 * transmitted, or when the ring is emtpy.

	 */

	if (ec->tx_coalesce_usecs || ec->tx_coalesce_usecs_high ||

	    ec->tx_coalesce_usecs_irq || ec->tx_coalesce_usecs_high ||

	    ec->tx_coalesce_usecs_low)

	    ec->tx_coalesce_usecs_irq || ec->tx_coalesce_usecs_low)

		return -EOPNOTSUPP;



	/* Program all TX queues with the same values, as there is no